fix: Make Datadog requirements optional #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to avoid requiring Datadog packages to be installed unless the
DatadogStatsLoggeris being used.Initially I used the same approach as the AI Assistant, removing it by default and providing comments in
plugins/stats_logger_plugin/__init__.pydetailing how to enable the DatadogStatsLogger.But then I realized I could leave it included but use a lazy import to achieve the same effect, without requiring users to mess with the plugins at all.
I think I prefer the lazy loading approach since it's simpler for users and keeps it as a "built-in" option, but either work.