Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to composite action? #33

Closed
5 of 7 tasks
jidicula opened this issue Jan 19, 2021 · 1 comment · Fixed by #75
Closed
5 of 7 tasks

Convert to composite action? #33

jidicula opened this issue Jan 19, 2021 · 1 comment · Fixed by #75
Labels
enhancement New feature or request question Further information is requested

Comments

@jidicula
Copy link
Owner

jidicula commented Jan 19, 2021 •
edited
Loading

Might allow for better caching... to investigate.

  • modify Dockerfile to use clang-format as ENTRYPOINT
  • set up composite action
  • refactor testing to call script on directory
  • add matrix for supported versions CI test
  • refactor script to pull Docker image and run from there
  • modify README to indicate new version support
  • new release
@jidicula jidicula added enhancement New feature or request question Further information is requested labels Jan 19, 2021
@jidicula
Copy link
Owner Author

Would require building clang-format from source. See https://github.com/Unibeautify/docker-beautifiers/blob/master/clang-format/Dockerfile

@jidicula jidicula mentioned this issue Dec 23, 2021
Closed
jidicula added a commit that referenced this issue Jan 9, 2022
@jidicula
feat(clang-format-docker): Add ENTRYPOINT for clang-format in img
9d8f7e9 
Related to: #33
@jidicula jidicula mentioned this issue Jan 9, 2022
Merged
jidicula added a commit that referenced this issue Jan 9, 2022
@jidicula
feat(clang-format-docker): Add ENTRYPOINT for clang-format in img
4167c3b 
Related to: #33
@jidicula jidicula mentioned this issue Jan 9, 2022
Merged
@jidicula jidicula mentioned this issue Jan 15, 2022
Merged
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
feat(clang-format docker): Use Ubuntu as base image
dba7e75 
Also inject Ubuntu version and `clang-format` version as build args,
and move install operation into image build.

Related to: #33
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
feat(clang-format docker): Use Ubuntu as base image
86947ab 
Also inject Ubuntu version and `clang-format` version as build args,
and move install operation into image build.

Related to: #33
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
refactor: Remove action Dockerfile and use clang-format Docker img
379ce4a 
Related to: #33
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
refactor(Action): Set up composite action
94f5c29 
Related to: #33
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
test: Refactor testing to use check.sh
5e67740 
Also adds matrix of supported versions to CI check.

Related to: #33
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
refactor: Remove action Dockerfile and use clang-format Docker img
0fc5c94 
Related to: #33
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
refactor(Action): Set up composite action
88be589 
Related to: #33
jidicula added a commit that referenced this issue Jan 15, 2022
@jidicula
test: Refactor testing to use check.sh
24a713b 
Also adds matrix of supported versions to CI check.

Related to: #33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor from Dockerfile Action to composite Action jidicula/clang-format-action
1 participant
@jidicula