-
-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Add sentry_organization_pagerduty_service
resource
#296
Conversation
I think it will be cool!!! |
Any further actions, guys? |
We really want this to land soon, how can we get it to move forward? |
…e extraction logic
4a2c112
to
81041da
Compare
I've resolved the merge conflict. It should be ready to go. |
👍 We are waiting for this feature to be available. |
Also waiting for this feature. Without it you need to:
The full process could be automated smoothly with this additional functionality in the Sentry module, so would be great to get it merged! |
04878ed
to
5515d24
Compare
This PR adds a
sentry_organization_pagerduty_service
resource. It handles a single service/integration key at a time, hiding the fact that the API requires POSTing a full list of all the services/integration keys. Any service/integration keys that aren't managed by terraform will be ignored and kept as-is.The resource has the form:
I've added integration tests that pass on my test instances of Sentry + PagerDuty. Since this requires paid plans for both services and I wasn't sure if the terraform-provider-sentry's test environment has this, I made the tests require the
SENTRY_TEST_PAGERDUTY_INTEGRATION_ID
environment variable to be set in order to run. Otherwise, the tests will be skipped.This PR depends on changes to the underlying go-sentry library to be merged and released (jianyuan/go-sentry#80). Once that's merged, I'll update this PR and switch the status out of draft.Fixes #250