Skip to content

Commit

Permalink
Extend the PR evaluator with generic params
Browse files Browse the repository at this point in the history
The PR evaluator used to have typed params for every function we'd add -
there's one for frizbee, one for the pull_request_content function etc.
This is not great, as we tie the functions to our protobuf API and every
new function requires a client release to be done or else the clients
can't even add ruletypes with the new functions.

Let's just use a generic `structpb.Struct` going forward. This time it
is still a change that needs client support, but going forward we'll
just have to change the server code to add a new function.
  • Loading branch information
jhrozek committed Oct 28, 2024
1 parent c8a0b7b commit 2e41532
Show file tree
Hide file tree
Showing 4 changed files with 1,477 additions and 1,452 deletions.
3 changes: 2 additions & 1 deletion docs/docs/ref/proto.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 5 additions & 1 deletion pkg/api/openapi/minder/v1/minder.swagger.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 2e41532

Please sign in to comment.