Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for fragment spread in interface #56

Merged
merged 2 commits into from
May 21, 2023

Conversation

devxoul
Copy link
Contributor

@devxoul devxoul commented Mar 14, 2023

This PR allows to generate code for the graphql below:

query GetNode($id: ID!) {
  node(id: $id) {
    ... on User {
      UserFragment
    }
    ... on Article {
      ArticleFragment
    }
  }
}

by adding base classes to the inline fragment classes:

  class GetNodeNodeUserInlineFragment(
+   UserFragment,
    GetNodeNodeBase
  ):

  class GetNodeNodeArticleInlineFragment(
+   ArticleFragment,   
    GetNodeNodeBase
  ):

@codecov
Copy link

codecov bot commented Mar 15, 2023

Codecov Report

Patch coverage: 33.33% and project coverage change: -0.35 ⚠️

Comparison is base (5b78fa2) 93.88% compared to head (0d30d92) 93.54%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   93.88%   93.54%   -0.35%     
==========================================
  Files          56       64       +8     
  Lines        3058     3423     +365     
==========================================
+ Hits         2871     3202     +331     
- Misses        187      221      +34     
Impacted Files Coverage Δ
turms/recurse.py 85.46% <33.33%> (-2.49%) ⬇️

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jhnnsrs
Copy link
Owner

jhnnsrs commented May 12, 2023

Hi,

thanks a lot for updating this! Could i bother you to write a test for this ? :)
Otherwise i can get to it next week ! :)

@jhnnsrs
Copy link
Owner

jhnnsrs commented May 21, 2023

Looks good to me! Tests will come later ;) Thanks a lot!

@jhnnsrs jhnnsrs merged commit b5adbf2 into jhnnsrs:master May 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants