Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inotify file watching with simplywatch #10

Merged
merged 1 commit into from
Apr 24, 2017

Conversation

gleclaire
Copy link

Replace inotify file watching with simplywatch ( https://github.com/danielkalen/simplywatch ) to allow stable file reloads on file changes

@PierreBesson
Copy link
Collaborator

Thank you ! I like this. Eventually when I have the time I would like to convert the consul loader from a bash script to a regular js cli program (I would release it on NPM and it can then be used without docker).

@PierreBesson PierreBesson merged commit 3e8de76 into jhipster:master Apr 24, 2017
@PierreBesson
Copy link
Collaborator

I just did a new release with this change.

@gleclaire
Copy link
Author

the npm idea sounds good. I still think the docker compose config like now make for a simple bootstrap for developers.
The consul-config-loader container could use the new npm watcher with the compose file helping the injection of the watch parameters.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants