Skip to content

Commit

Permalink
Merge pull request #77 from bobisjan/better-errors
Browse files Browse the repository at this point in the history
Show error with message in console
  • Loading branch information
jherdman authored Feb 6, 2017
2 parents f6cecde + 3bb5965 commit 349e5bf
Showing 1 changed file with 13 additions and 1 deletion.
14 changes: 13 additions & 1 deletion addon/utils/error-handler.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,18 @@ import Ember from 'ember';

const Logger = Ember.Logger;

// https://github.com/emberjs/ember.js/blob/master/packages/ember-metal/lib/error_handler.js#L4-L14
const getStack = error => {
let stack = error.stack;
let message = error.message;

if (stack && !stack.includes(message)) {
stack = `${message}\n${stack}`;
}

return stack;
};

class ErrorHandler {
constructor(reporter) {
this.reporter = reporter;
Expand All @@ -14,7 +26,7 @@ class ErrorHandler {
// If the error is an Error object, we pass it directly.
if (error instanceof Error) {
this.reporter.track(error);
Logger.error(error.stack);
Logger.error(getStack(error));

return;
}
Expand Down

0 comments on commit 349e5bf

Please sign in to comment.