Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged your improvement to original picocom #1

Open
npat-efault opened this issue Aug 6, 2015 · 2 comments
Open

Merged your improvement to original picocom #1

npat-efault opened this issue Aug 6, 2015 · 2 comments

Comments

@npat-efault
Copy link

Hi,

I'm the original author of picocom.

Someone tipped me about your fork. Having line-editing and path-completion support when entering filenames for send- and receive- file operations is indeed very neat! Furthermore the linenoise library has adequately small footprint to affect only minimally the "pico" character of picocom.

So, I have merged your additions / improvements to the original picocom with a couple of very minor tweaks: I made the linenoise support optional (you can compile it out by commenting-out a couple of lines in the Makefile). I changed the way C-c is handled when entering a filename (the transfer operation is canceled, instead of exiting picocom). I fixed a potential bug in init_send_receive_history() (I'll file a separate issue for this). And... that's all.

I hope you don't mind.

It would be great if you could take a look at my merge and see if I have fucked-up something obvious...

The code can be checked out from the SVN trunk by:

  svn http://picocom.googlecode.com/svn/trunk/ ./picocom

Soon I will stamp-out a new release (1.8) with the new features.

Thanks for helping improve picocom!

Cheers
/npat

@npat-efault
Copy link
Author

Since it seems that googlecode is closing down, I have moved the picocom project to github.

https://github.com/npat-efault/picocom

The commit that contains the relevant changes is: npat-efault/picocom@6b824ee

@jhandley
Copy link
Owner

Nick,

Sorry for taking so long to reply. I'm really happy to see these changes
getting into picocom. At my last job we were developing for a medical
device and used picocom to update programs on the device via the serial
connection constantly so having the completion was a huge help.
Unfortunately I'm no longer at that job but the colleagues I left behind
will be thrilled. I looked over your changes and they look good. I don't
have the dev environment setup anymore to test it out.

Josh

On 8/6/2015 10:09 PM, Nick Patavalis wrote:

Since it seems that googlecode is closing down, I have moved the
picocom project to github.

https://github.com/npat-efault/picocom

The commit that contains the relevant changes is:

|6b824ee71aecee6a0088aa7e2e6967baff7a73b7
|


Reply to this email directly or view it on GitHub
#1 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants