[SX128x] Save context before sleep to allow TX to work on wake (#1249) #1250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #1249 |
|
Thank you for the contribution! It looks like I missed this in the SX1280 driver implementation. Though in my defense on the SX126x (which has nearly identical SPI interface), this configuration is not needed. All loooks good - merged, thanks again! |
|
It's a weird one to be honest. I only figured out what the issue was by
taking a look at the source of Stuart's Lib "SX12XX Arduino".
…On 24/10/02 09:00am, Jan Gromeš wrote:
Thank you for the contribution! It looks like I missed this in the SX1280 driver implementation. Though in my defense on the SX126x (which has nearly identical SPI interface), this configuration is not needed.
All loooks good - merged, thanks again!
--
Reply to this email directly or view it on GitHub:
#1250 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.