Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ipynb reader: add text/markdown support in handleData #7561

Merged
merged 1 commit into from
Sep 10, 2021
Merged

Ipynb reader: add text/markdown support in handleData #7561

merged 1 commit into from
Sep 10, 2021

Conversation

ickc
Copy link
Contributor

@ickc ickc commented Sep 9, 2021

As of IPython version

import IPython

print(IPython.__version__)
7.25.0

it supports the following mime-types in output cell:

ip = get_ipython()
for mime in ip.display_formatter.formatters:
    print(mime)
text/plain
text/html
text/markdown
image/svg+xml
image/png
application/pdf
image/jpeg
text/latex
application/json
application/javascript

This PR add support to the only one not already supporting: text/markdown

@ickc ickc changed the title Ipynb reader handleData add text/markdown Ipynb reader: add text/markdown support in handleData Sep 9, 2021
@jgm jgm merged commit 1481dae into jgm:master Sep 10, 2021
jgm pushed a commit that referenced this pull request Dec 10, 2021
Write RawBlock of markdown in code-cell output.

#7561 makes the ipynb reader reads code-cell output with mime
"text/markdown" to a RawBlock of markdown

This commit makes the ipynb writer writes this RawBlock of markdown
back inside a code-cell output with the same mime, preserving this
information in round-trip

Add tests of ipynb reader (#7561) and ipynb writer (#7563)'s ability to
handle a "text/markdown" mime type in a code-cell output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants