Add Muse writer #3489
Add Muse writer #3489
Conversation
pandoc.cabal
Outdated
| @@ -180,6 +181,7 @@ Extra-Source-Files: | |||
| test/writer.markdown | |||
| test/writer.plain | |||
| test/writer.mediawiki | |||
| test/writer.muse | |||
There was a problem hiding this comment.
I think you need to add test/writer.muse to the repository -- I don't see it here in this PR.
There was a problem hiding this comment.
I don't have it actually. I added it when I began development, but removed it then as I thought it was deprecated as it was referred from test/Tests/Old.hs. Instead I made a comprehensive unit test suite.
Should I add it or are we moving towards unit tests?
README.md
Outdated
| @@ -26,7 +26,7 @@ write plain text, [Markdown], [CommonMark], [PHP Markdown Extra], | |||
| [DocBook], [OpenDocument], [ODT], [Word docx], [GNU Texinfo], [MediaWiki | |||
| markup], [DokuWiki markup], [ZimWiki markup], [Haddock markup], | |||
| [EPUB] \(v2 or v3\), [FictionBook2], [Textile], [groff man] pages, | |||
| [Emacs Org mode], [AsciiDoc], [InDesign ICML], [TEI Simple], and [Slidy], | |||
| [Emacs Org mode], [AsciiDoc], [InDesign ICML], [TEI Simple], [Muse] and [Slidy], | |||
There was a problem hiding this comment.
Let's put a comma after [Muse] here; it makes it clearer that it's not one of the slide show formats.
pandoc.cabal
Outdated
| @@ -24,7 +24,7 @@ Description: Pandoc is a Haskell library for converting from one markup | |||
| Word docx, RTF, MediaWiki, DokuWiki, ZimWiki, Textile, | |||
| groff man pages, plain text, Emacs Org-Mode, AsciiDoc, | |||
| Haddock markup, EPUB (v2 and v3), FictionBook2, InDesign ICML, | |||
| and several kinds of HTML/javascript slide shows (S5, Slidy, | |||
| Muse and several kinds of HTML/javascript slide shows (S5, Slidy, | |||
deb/control.in
Outdated
| @@ -16,5 +16,5 @@ Description: general markup converter | |||
| Docbook, OPML, OpenDocument, ODT, Word docx, RTF, MediaWiki, | |||
| DokuWiki, Textile, groff man pages, plain text, Emacs Org-Mode, | |||
| AsciiDoc, Haddock markup, EPUB (v2 and v3), FictionBook2, | |||
| InDesign ICML, and several kinds of HTML/javascript | |||
| InDesign ICML, Muse and several kinds of HTML/javascript | |||
src/Text/Pandoc/Writers/Muse.hs
Outdated
| @@ -0,0 +1,329 @@ | |||
| {-# LANGUAGE OverloadedStrings #-} | |||
| {- | |||
| Copyright (C) 2010-2017 John MacFarlane <[email protected]> | |||
There was a problem hiding this comment.
You should put your own name and 2017 here.
|
This basically looks great. I've made a couple of minor comments. |
link2xt
force-pushed
the
muse
branch
2 times, most recently
from
9b56694 to
197b885
Compare
|
@jgm I have fixed what you proposed. As for Also, just in case you have not noticed, I have not added Muse into the list of formats in |
|
I think we should add it. Unit tests are still good, but
we have both for a number of the other writers. Since this
test converts a document containing most document features,
it gives good coverage.
You can generate it easily. Just add an empty
test/writer.muse, and run the test suite. It will fail
and tell you the exact command you can use to regenerate
test/writer.muse. Generate it and check it very carefully
for correctness. If everything looks good, commit it.
|
|
+++ Alexander Krotov [Mar 06 17 11:39 ]:
Also, just in case you have not noticed, I have not added Muse into the
list of formats in man/pandoc.1 because I think it is regenerated
anyway when release is made.
Correct.
|
link2xt
force-pushed
the
muse
branch
4 times, most recently
from
cbed8d4 to
eb37daf
Compare
|
Found some bugs to fix:
Non-critical, might just document them:
|
link2xt
force-pushed
the
muse
branch
2 times, most recently
from
27f70c5 to
b9d82f5
Compare
|
Let me know when you're ready to merge. I wasn't sure if you were planning to do something about the accidental lists issue. |
|
@jgm I will not change this branch anymore and push all new changes into another branch, like |
Closes #3405