Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix UI block during scan and cancel auto scan when loading the extension tool panel #52

Merged
merged 12 commits into from
Jan 13, 2025
Merged

Fix UI block during scan and cancel auto scan when loading the extension tool panel #52

merged 12 commits into from
Jan 13, 2025

Conversation

kerenr-jfrog
Copy link
Contributor

@kerenr-jfrog kerenr-jfrog commented Jan 12, 2025 •
edited
Loading

  • The pull request is targeting the dev branch.
  • All tests passed. If this feature is not already covered by the tests, I added new tests.
  • Fixed bug that caused UI block during scan.
  • Cancel auto scan when loading the Jfrog extension tool panel. Scan will be performed only by clicking the refresh button.
  • Updated project dependencies to fix build issues in the build workflow.
  • Changed the audit command to scan only SCA in order to decrease scan process duration.
  • Added UI message that indicates a scan is in progress.
  • Added vertical scroll bar for components details view.

@kerenr-jfrog kerenr-jfrog changed the title Fix UI block during scan Fix UI block during scan and cancel auto scan when loading the extension tool panel Jan 12, 2025
@kerenr-jfrog kerenr-jfrog changed the base branch from master to dev January 12, 2025 08:26
@kerenr-jfrog kerenr-jfrog self-assigned this Jan 12, 2025
@kerenr-jfrog kerenr-jfrog added the bug Something isn't working label Jan 12, 2025
@kerenr-jfrog kerenr-jfrog requested a review from attiasas January 13, 2025 11:33
@kerenr-jfrog kerenr-jfrog marked this pull request as ready for review January 13, 2025 11:34
@github-actions GitHub Actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.

attiasas
attiasas approved these changes Jan 13, 2025
View reviewed changes
Copy link

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kerenr-jfrog kerenr-jfrog merged commit c256bc7 into jfrog:dev Jan 13, 2025
4 checks passed
@kerenr-jfrog kerenr-jfrog deleted the fix-ui-block-during-scan branch January 13, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@attiasas attiasas attiasas approved these changes

Assignees

@kerenr-jfrog kerenr-jfrog

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kerenr-jfrog @attiasas