Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support maven.deploy.skip property on a module #43

Merged
merged 1 commit into from
Nov 23, 2022
Merged

Support maven.deploy.skip property on a module #43

merged 1 commit into from
Nov 23, 2022

Conversation

yahavi
Copy link
Member

@yahavi yahavi commented Nov 22, 2022

  • All tests passed. If this feature is not already covered by the tests, I added new tests.

Resolves #39

Allow skipping deployment of module artifacts using the maven.deploy.skip property:

<properties>
    <maven.deploy.skip>true</maven.deploy.skip>
</properties>

@yahavi yahavi requested a review from eyalbe4 November 22, 2022 10:02
@yahavi yahavi self-assigned this Nov 22, 2022
@yahavi yahavi mentioned this pull request Nov 22, 2022
Closed
@yahavi yahavi added the improvement Automatically generated release notes label Nov 22, 2022
TobiX
TobiX approved these changes Nov 22, 2022
View reviewed changes
Copy link

@TobiX TobiX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like it would address my primary use-case.

@yahavi yahavi merged commit 642145b into jfrog:master Nov 23, 2022
@yahavi yahavi deleted the skip-deploy branch November 23, 2022 15:45
@yahavi yahavi mentioned this pull request Nov 24, 2022
Closed
1 task
@hochrai hochrai mentioned this pull request Nov 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobiX TobiX TobiX approved these changes

@eyalbe4 eyalbe4 eyalbe4 approved these changes

Assignees

@yahavi yahavi

Labels
improvement Automatically generated release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deploys artifacts when maven.deploy.skip is true
3 participants
@yahavi @TobiX @eyalbe4