Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should be compatible with the upcoming 4.x Maven release #70

Closed
erikgb opened this issue May 30, 2023 · 0 comments · Fixed by #83
Closed

Should be compatible with the upcoming 4.x Maven release #70

erikgb opened this issue May 30, 2023 · 0 comments · Fixed by #83
Labels
bug Something isn't working

Comments

@erikgb
Copy link

erikgb commented May 30, 2023

Describe the bug

When enabling plugin validation I see some warnings about this plugin not being ready for Maven 4.x. This should be fixed.

Current behavior

[WARNING]    * Plugin depends on the deprecated Maven 2.x compatibility layer, which may not be supported in Maven 4.x
[WARNING]    * Plugin should declare these Maven artifacts in `provided` scope: [org.apache.maven:maven-compat:3.8.6, org.apache.maven:maven-resolver-provider:3.8.6, org.apache.maven:maven-settings-builder:3.8.6, org.apache.maven:maven-repository-metadata:3.8.6, org.apache.maven:maven-core:3.8.6, org.apache.maven:maven-model-builder:3.8.6, org.apache.maven:maven-plugin-api:3.8.6, org.apache.maven:maven-model:3.8.6, org.apache.maven:maven-builder-support:3.8.6, org.apache.maven:maven-settings:3.8.6]
[WARNING] 
[WARNING]  * org.jfrog.buildinfo:artifactory-maven-plugin:3.6.1
[WARNING]   Declared at location(s):
[WARNING]    * <REDACTED>
[WARNING]   Used in module(s):
[WARNING]    * <REDACTED> (pom.xml)
[WARNING]   Plugin issue(s):
[WARNING]    * Plugin should declare these Maven artifacts in `provided` scope: [org.apache.maven:maven-artifact:3.3.9, org.apache.maven:maven-settings-builder:3.3.9, org.apache.maven:maven-repository-metadata:3.3.9, org.apache.maven:maven-builder-support:3.3.9, org.apache.maven:maven-core:3.3.9, org.apache.maven:maven-aether-provider:3.3.9, org.apache.maven:maven-settings:3.3.9, org.apache.maven:maven-plugin-api:3.3.9, org.apache.maven:maven-model-builder:3.3.9, org.apache.maven:maven-model:3.3.9]
[WARNING] 
[WARNING] 
[WARNING] Fix reported issues by adjusting plugin configuration or by upgrading above listed plugins. If no upgrade available, please notify plugin maintainers about reported issues.

Reproduction steps

  • Start with a Maven project configured with this plugin.
  • Run the build with a recent version of Maven (we use version 3.9.2)
  • Supply the following CLI argument: -Dmaven.plugin.validation=VERBOSE

Expected behavior

No warnings about this plugin emitted.

Artifactory Maven plugin version

3.6.1

Operating system type and version

N/A

JFrog Artifactory version

N/A

Maven version

3.9.2

@erikgb erikgb added the bug Something isn't working label May 30, 2023
slawekjaranowski added a commit to slawekjaranowski/artifactory-maven-plugin that referenced this issue Oct 12, 2023
slawekjaranowski added a commit to slawekjaranowski/artifactory-maven-plugin that referenced this issue Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant