Quoted Request Log #12834 #12835
Merged
Quoted Request Log #12834 #12835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quote values that need to be quoted Track quotes in format string.
gregw
requested review from
lachlan-roberts and
lorban
and removed request for
lachlan-roberts
janbartel
previously approved these changes
Feb 28, 2025
lachlan-roberts
requested changes
Mar 1, 2025
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/CustomRequestLog.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/CustomRequestLog.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/CustomRequestLog.java
Show resolved
Hide resolved
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/CustomRequestLog.java
Show resolved
Hide resolved
lorban
previously approved these changes
Mar 3, 2025
sbordet
requested changes
Mar 3, 2025
| { | ||
| } | ||
|
|
||
| //-----------------------------------------------------------------------------------// |
There was a problem hiding this comment.
Let's get rid of these separators, here and in the method above.
|
|
||
| HttpTester.Response response = getResponse(""" | ||
| GET / HTTP/1.0 | ||
| User-Agent: bad"value |
There was a problem hiding this comment.
I tried to motify this test with User-Agent: bad\\"value, as if an application had already escaped the dquote.
The result is: "User-Agent: \"bad\\\\\\\"value\", \"bad\\\\\\\"value\"".
Is this expected? I would have expected the original value (perhaps quoted), which was already properly escaped.
Signed-off-by: Simone Bordet <[email protected]>
sbordet
approved these changes
Mar 3, 2025
lachlan-roberts
approved these changes
Mar 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12834 Quote request log values that need to be quoted
Track quotes in format string.