Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce UriCompliance.JETTY_11 which is different than UriCompliance.LEGACY #12827

Merged
merged 10 commits into from
Feb 28, 2025

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Feb 26, 2025

Tests for #12809

@gregw gregw requested a review from joakime February 26, 2025 10:14
@gregw gregw added the Sponsored This issue affects a user with a commercial support agreement label Feb 26, 2025
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some needed updates on UriCompliance, and a question.

@gregw
Copy link
Contributor Author

gregw commented Feb 28, 2025

@joakime @lachlan-roberts nudge

janbartel
janbartel previously approved these changes Feb 28, 2025
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments only.

@gregw gregw self-assigned this Feb 28, 2025
@joakime
Copy link
Contributor

joakime commented Feb 28, 2025

The last javadoc fix is building, but the previous build was green.
I'm going to merge this now.

@joakime joakime merged commit 4d10c20 into jetty-12.0.x Feb 28, 2025
3 of 6 checks passed
@joakime joakime deleted the fix/12809/LEGACY_URI branch February 28, 2025 17:10
@joakime joakime changed the title Added tests for legacy URI compliance Introduce UriCompliance.JETTY_11 which is different than UriCompliance.LEGACY Feb 28, 2025
joakime added a commit that referenced this pull request Feb 28, 2025
 UriCompliance.LEGACY (#12827)

* Added new UriCompliance.JETTY_11
* Updating tests for UriCompliance.LEGACY
* Updating tests for UriCompliance.JETTY_11
paulrutter added a commit to apache/felix-dev that referenced this pull request Mar 6, 2025
- Add JETTY_11 to list of possible enums that require setting `setDecodeAmbiguousURIs`, see jetty/jetty.project#12827
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Review UriCompliance.LEGACY and its omission of SUSPICIOUS_PATH_CHARACTERS
4 participants