Issue #12775 avoid unnecessary exception in getInputStream #12789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbordet
previously approved these changes
Feb 12, 2025
|
@sbordet this now contains some of my work, so can you review instead of me? |
sbordet
approved these changes
Feb 26, 2025
joakime
changed the title
|
Merged all the way to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #12775
Calling
request.getInputStream()causes an attempt to write a100 Continueto the response: if the request did not contain theExpect 100header, we create an exception and then ignore it.This PR only attempts to write the
100 Continueiff the request has anExpect 100header, thus saving the cpu cycles involved in creating the useless exception with stack traces etc.