Issue #12714 verify workername for Mongo usage #12715
Conversation
| @@ -159,6 +157,8 @@ public class MongoSessionDataStore extends NoSqlSessionDataStore | |||
| */ | |||
| private DBObject _version1; | |||
|
|
|||
| private final Pattern _workerNamePattern = Pattern.compile("[0-9a-zA-Z]*"); | |||
There was a problem hiding this comment.
Not that it will make any difference, but:
| private final Pattern _workerNamePattern = Pattern.compile("[0-9a-zA-Z]*"); | |
| private final static Pattern __workerNamePattern = Pattern.compile("[0-9a-zA-Z]*"); |
| @@ -159,6 +157,8 @@ public class MongoSessionDataStore extends NoSqlSessionDataStore | |||
| */ | |||
| private DBObject _version1; | |||
|
|
|||
| private final Pattern _workerNamePattern = Pattern.compile("[0-9a-zA-Z]*"); | |||
There was a problem hiding this comment.
Underscore is a valid character, too.
Adding it would allow the name to support snake case.
| return; | ||
|
|
||
| if (!_workerNamePattern.matcher(_context.getWorkerName()).matches()) | ||
| throw new IllegalStateException("Invalid worker name: " + _context.getWorkerName()); |
There was a problem hiding this comment.
Works like a charm!
Only improvement might be stating what's valid, so if the issue is encountered it'd be fixable without diving into the code and looking up the Pattern
|
Hmm maybe I am missing something but I see the index https://www.mongodb.com/docs/manual/core/indexes/index-types/index-text/ This means the index can be replaced with a regular unique index and handle any worker name. Or even more simpler to use the |
|
@qtxo looks right. But not related to this change. Can you please create a separate issue or pull request? |
Fixes #12714
The
workerNameconfigured on theDefaultSessionIdManagercan be unacceptable toMongoDB. TheDefaultSessionIdManagerprepends theworkerNameonto the generated random id to form a session id. If thisworkerNamecontains punctuation or other delimiter type characters, this messes with theMongoDBindex over the session ids.This PR allows
MongoSessionDataStoreto check theworkerNameat startup and fail the startup if it isn't admissible.