Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check UriCompliance.Violation.ALLOW_BAD_UTF8 in query parameter extraction #12671

Merged
merged 3 commits into from
Jan 6, 2025

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Jan 5, 2025

Restore legacy behaviour of using replacement characters for bad UTF8 in query parameters.

@gregw gregw added the Sponsored This issue affects a user with a commercial support agreement label Jan 5, 2025
@gregw
Copy link
Contributor Author

gregw commented Jan 5, 2025

I also added support for core and EE10

@gregw gregw requested review from joakime and janbartel January 6, 2025 04:00
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs the tracking of violations part, otherwise it looks good.

@gregw gregw changed the title Check UriCompliance.Violation.ALLOW_BAD_UTF8 in EE9 query parameter extraction Check UriCompliance.Violation.ALLOW_BAD_UTF8 in query parameter extraction Jan 6, 2025
…extraction.

Added compliance violation listeners
@gregw gregw requested a review from joakime January 6, 2025 20:56
@gregw gregw merged commit 2d9dab6 into jetty-12.0.x Jan 6, 2025
10 checks passed
@gregw gregw deleted the fix/jetty-12/allowBadUtfInEE9Query branch January 6, 2025 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants