Issue when scrolling around in embedded videos

[mwalsh-etiometry]

Jetty Version
Jetty 12.0.15 and 12.0.16

Jetty Environment
ee10

Java Version
openjdk 17.0.2

Question
When we upgraded from Jetty 11 to Jetty 12.0.15, the embedded videos in our application started throwing 416 errors. Upon looking into the Jetty ResourceServlet code, it looks like if the servlet response is no longer of type ServletApiResponse, the content gets wrapped as a UnknownLengthHttpContent. Thus, in ResourceService, ByteRange.parse cannot find the satisfiable ranges.

We're running into an issue where our servlet response is getting wrapped by our usage of Spring Security and the filter logic supplied there. However, it appears the logic in ResourceServlet is intentional in this, stating -

// Servlet Filters could be interacting with the Response already.
                if (useServletResponse)
                    content = new UnknownLengthHttpContent(content);

What is the intended way for this to work and what should we be doing to solve for this? Or is this behavior unintentional and therefore a bug? For now, we have built out our own Servlet which unwraps the response for those video requests but that doesn't seem the the appropriate long term solution.

[janbartel]

@gregw looking at the code in ResourceServlet, I don't see why we are wrapping the HttpContent as an UnknownLengthHttpContent if a filter has wrapped the response? Maybe in the case where the wrapped response has already been written to it may make sense, but not otherwise.

[janbartel]

@gregw nudge?