Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configurable capping for values of H2 MAX_HEADER_LIST_SIZE settings frames #12690

Closed
lorban opened this issue Jan 9, 2025 · 2 comments · Fixed by #12699
Closed

Add configurable capping for values of H2 MAX_HEADER_LIST_SIZE settings frames #12690

lorban opened this issue Jan 9, 2025 · 2 comments · Fixed by #12699
Assignees
@lorban
Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement

Comments

@lorban
Copy link
Contributor

lorban commented Jan 9, 2025 •
edited
Loading

Jetty version(s)
12.0.x

Enhancement Description
Currently, HTTP2Session.configure() does not cap the values of the MAX_HEADER_LIST_SIZE settings frames.

We should add new config settings to control this capping.
@lorban lorban added Enhancement Sponsored This issue affects a user with a commercial support agreement labels Jan 9, 2025
@lorban lorban self-assigned this Jan 9, 2025
@lorban lorban changed the title Add configurable capping for values of H2 MAX_FRAME_SIZE and MAX_HEADER_LIST_SIZE settings frames Add configurable capping for values of H2 MAX_FRAME_SIZE and MAX_HEADER_LIST_SIZE settings frames Jan 9, 2025
@lorban lorban moved this to 🏗 In progress in Jetty 12.0.17 - FROZEN Jan 9, 2025
@sbordet
Copy link
Contributor

sbordet commented Jan 9, 2025

MAX_FRAME_SIZE does not need capping, because it is only used for sanity checks.

But MAX_HEADER_LIST_SIZE must be capped because it is used for allocating buffers.

@lorban lorban changed the title Add configurable capping for values of H2 MAX_FRAME_SIZE and MAX_HEADER_LIST_SIZE settings frames Add configurable capping for values of H2 MAX_HEADER_LIST_SIZE settings frames Jan 9, 2025
@lorban
Copy link
Contributor Author

lorban commented Jan 9, 2025

@sbordet thanks, I've updated both the title and the description to reflect this.

lorban added a commit that referenced this issue Jan 10, 2025
@lorban
#12690 cap MAX_HEADER_LIST_SIZE
9a44908 
Signed-off-by: Ludovic Orban <[email protected]>
@lorban lorban mentioned this issue Jan 10, 2025
Merged
lorban added a commit that referenced this issue Jan 10, 2025
@lorban
#12690 fix test
652583c 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Jan 13, 2025
@lorban
#12690 cap MAX_HEADER_LIST_SIZE
8414f79 
Signed-off-by: Ludovic Orban <[email protected]>
lorban added a commit that referenced this issue Jan 13, 2025
@lorban
#12690 fix test
c8c2515 
Signed-off-by: Ludovic Orban <[email protected]>
@github-project-automation github-project-automation bot moved this from 🏗 In progress to ✅ Done in Jetty 12.0.17 - FROZEN Jan 13, 2025
@jrauschenbusch jrauschenbusch mentioned this issue Feb 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lorban lorban

Labels
Enhancement Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 12.0.17 - FROZEN
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Cap H2 MAX_HEADER_LIST_SIZE according to config jetty/jetty.project
2 participants
@sbordet @lorban