Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[zeroconfig] Implement nodejs detector #2395

Merged
merged 1 commit into from
Oct 30, 2024
Merged

[zeroconfig] Implement nodejs detector #2395

merged 1 commit into from
Oct 30, 2024

Conversation

mikeland73
Copy link
Contributor

Summary

TSIA

Possible improvement: should we default DEVBOX_COREPACK_ENABLED to true? (cc: @LucilleH )

How was it tested?

  • unit tests
  • Manually created directory with package.json

LucilleH
LucilleH approved these changes Oct 30, 2024
View reviewed changes
Copy link
Collaborator

@LucilleH LucilleH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes DEVBOX_COREPACK_ENABLED should be true by default

@mikeland73 mikeland73 merged commit 8bfe8b3 into main Oct 30, 2024
29 checks passed
@mikeland73 mikeland73 deleted the landau/autodetect-node branch October 30, 2024 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LucilleH LucilleH LucilleH approved these changes

@gcurtis gcurtis Awaiting requested review from gcurtis

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mikeland73 @LucilleH