Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: visibilize todos #34

Merged
merged 1 commit into from
Apr 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,4 +30,4 @@ task build

## Release

TODO
TODO(#32)
2 changes: 1 addition & 1 deletion examples/probe.go
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
package examples

// TODO
// TODO(#28)
2 changes: 0 additions & 2 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,6 @@ const (
`
)

// TODO: Support passing a custom remote server as an argument.

// CLI initialization.
func main() {
ctx, cancel := context.WithCancel(context.Background())
Expand Down
1 change: 0 additions & 1 deletion pkg/probe.go
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ type Probe struct {
// Delay between requests.
Delay time.Duration
// Time to wait for a response.
// TODO: Support specific timeouts per protocol.
Timeout time.Duration
// For debugging purposes.
Logger *slog.Logger
Expand Down
3 changes: 1 addition & 2 deletions pkg/protocol.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ func (p *Protocol) String() string {
// The extra information is the status code.
func requestHTTP(u string, timeout time.Duration) (string, error) {
cli := &http.Client{Timeout: timeout}
// TODO: Reuse client
resp, err := cli.Get(u)
if err != nil {
return "", fmt.Errorf("making request to %s: %w", u, err)
Expand Down Expand Up @@ -74,7 +73,7 @@ func requestTCP(hostPort string, timeout time.Duration) (string, error) {
// Resolves a domain name.
//
// The extra information is the first resolved IP address.
// TODO: Support custom DNS resolver.
// TODO(#31)
func requestDNS(domain string, timeout time.Duration) (string, error) {
addrs, err := net.LookupHost(domain)
if err != nil {
Expand Down
Loading