Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update setup instructions for typescript files #8624

Merged
merged 2 commits into from
Jun 30, 2019

Conversation

joeldenning
Copy link
Contributor

Summary

Typescript files require .ts or .tsx file extension. Now that babel can parse typescript with @babel/preset-typescript, we should use it.

Test plan

I tried this out locally and it worked for both typescript and js files.

@codecov-io
Copy link

codecov-io commented Jun 29, 2019

Codecov Report

Merging #8624 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #8624   +/-   ##
======================================
  Coverage    63.4%   63.4%           
======================================
  Files         274     274           
  Lines       11342   11342           
  Branches     2770    2770           
======================================
  Hits         7191    7191           
  Misses       3534    3534           
  Partials      617     617

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f787d...e7f3197. Read the comment docs.

Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@SimenB SimenB merged commit 2b64bb4 into jestjs:master Jun 30, 2019
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants