Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jest-config): use graceful-fs replace realpath-native #8530

Closed
wants to merge 1 commit into from

Conversation

bluelovers
Copy link

Summary

#7978

Test plan

@facebook-github-bot
Copy link
Contributor

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

@codecov-io
Copy link

Codecov Report

Merging #8530 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #8530   +/-   ##
=======================================
  Coverage   60.56%   60.56%           
=======================================
  Files         269      269           
  Lines       11045    11045           
  Branches     2690     2690           
=======================================
  Hits         6689     6689           
  Misses       3770     3770           
  Partials      586      586
Impacted Files Coverage Δ
packages/jest-config/src/getCacheDirectory.ts 66.66% <ø> (ø) ⬆️
packages/jest-config/src/normalize.ts 77.92% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8212e62...d385654. Read the comment docs.

@SimenB
Copy link
Member

SimenB commented Apr 28, 2020

We explicitly want to use the native realpath here, so this isn't the correct fox unfortunately...

@SimenB SimenB closed this Apr 28, 2020
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants