Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jest jasmine/ts migration #7970
Jest jasmine/ts migration #7970
Changes from 7 commits
a9fb41b
239e2c7
09867ae
0d4c004
f57370a
f9d1025
e2877b0
d00496a
eee8339
5ef9829
2d14cf1
bc6d48f
d2b3eba
b52c8f2
a3263b5
d5a4c17
b73f4b7
67a046a
69a427e
645bc92
03ec289
7aeeb6f
26c59b5
7f76abb
0625619
14a1564
9a9c65f
f9106ef
b9b422a
ee9d572
93f7414
8e3ecd8
cf01cf9
b89e537
548f05f
8e264a3
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests looks like they belong in
expect
, don't they?/cc @pedrottimark
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I will make sure that
expect
covers these test cases.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here - seems like they should be in
expect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one might be needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but it doesn't test anything jasmine? I don't understand what it means by "proxies to expect" - it uses
expect
directlyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In other words, Jest test suite is integration test that
expect
works in jasmine.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right - if
expect
didn't work in jasmine, the whole test suite would fail. The advantage of using Jest to test Jest 🙂