expect: Make change requested in toThrowMatchers

[pedrottimark]

Summary

• Simplify ternary expression, see expect: fix regression in toThrow for message prop and asymmetric matchers #7697 (comment)
• Factor out hasMessage but leave explicit strict equality conditions, see expect: fix regression in toThrow for message prop and asymmetric matchers #7697 (review)
• Attempted to import AsymmetricMatcher with added asymmetricMatch property from types/Matchers.js but Flow reported type errors, see expect: fix regression in toThrow for message prop and asymmetric matchers #7697 (comment)

Not necessary to update change log, true?

Test plan

All existing tests pass

[SimenB]

Not necessary to update change log, true?

Nope 🙂

[pedrottimark]

@SimenB do you have style preference between if-return-followed-by-return versus return ternary?

[SimenB]

Personally, not really. If the ternary is short enough (usually return thing ? left: right) I think that's fine. But if it's thisThing === 'maybe' && thisOtherThing ? left: right then I find it less readable

[codecov-io]

Codecov Report

Merging #7718 into master will not change coverage.
The diff coverage is 100%.

@@           Coverage Diff           @@
##           master    #7718   +/-   ##
=======================================
  Coverage   68.27%   68.27%           
=======================================
  Files         252      252           
  Lines        9682     9682           
  Branches        6        5    -1     
=======================================
  Hits         6610     6610           
  Misses       3070     3070           
  Partials        2        2

Impacted Files	Coverage Δ
packages/expect/src/toThrowMatchers.js	97.59% <100%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88713fc...8b25296. Read the comment docs.

[github-actions]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.