-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update pretty-format. #1715
Update pretty-format. #1715
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would honestly prefer that changes like this be in a major release... Seriously, pushing out changes to people who depend on semver that will result in breaking builds is a great way to frustrate a community.
I appreciate the desire to keep the version number from skyrocketing, but... it's just a number...
0 | ||
] | ||
0, | ||
], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comma dangle is a good call 👍 Makes git diffs much better.
yap, that's fair. We might tag it 16.0 next week. |
One drawback to releasing major versions is people may not know that there are new versions available. AVA (and many other CLIs) solve this problem using a module like |
d5fd945
to
96c347b
Compare
Current coverage is 90.17% (diff: 100%)@@ master #1715 diff @@
==========================================
Files 31 31
Lines 1170 1170
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1055 1055
Misses 115 115
Partials 0 0
|
96c347b
to
a0b9349
Compare
a0b9349
to
3c66ef7
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
See #1671
This updates Jest to pretty-format 4.0. This version now always prints trailing commas so all snapshots will be invalidated once people upgrade to 15.2.0.
Test plan
jest