Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pretty-format. #1715

Merged
merged 1 commit into from
Sep 20, 2016
Merged

Update pretty-format. #1715

merged 1 commit into from
Sep 20, 2016

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Sep 16, 2016

Summary
See #1671

This updates Jest to pretty-format 4.0. This version now always prints trailing commas so all snapshots will be invalidated once people upgrade to 15.2.0.

Test plan
jest

@ghost ghost added the CLA Signed ✔️ label Sep 16, 2016
Copy link
Contributor

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would honestly prefer that changes like this be in a major release... Seriously, pushing out changes to people who depend on semver that will result in breaking builds is a great way to frustrate a community.

I appreciate the desire to keep the version number from skyrocketing, but... it's just a number...

0
]
0,
],
Copy link
Contributor

@kentcdodds kentcdodds Sep 16, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comma dangle is a good call 👍 Makes git diffs much better.

@cpojer
Copy link
Member Author

cpojer commented Sep 16, 2016

yap, that's fair. We might tag it 16.0 next week.

@kentcdodds
Copy link
Contributor

One drawback to releasing major versions is people may not know that there are new versions available. AVA (and many other CLIs) solve this problem using a module like update-notifier

@codecov-io
Copy link

codecov-io commented Sep 17, 2016

Current coverage is 90.17% (diff: 100%)

Merging #1715 into master will not change coverage

@@             master      #1715   diff @@
==========================================
  Files            31         31          
  Lines          1170       1170          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1055       1055          
  Misses          115        115          
  Partials          0          0          

Powered by Codecov. Last update ba12cfa...96c347b

@cpojer cpojer merged commit 7b6a49c into jestjs:master Sep 20, 2016
mthmulders pushed a commit to mthmulders/jest that referenced this pull request Oct 10, 2016
@cpojer cpojer deleted the pretty-format branch May 4, 2017 15:44
tushardhole pushed a commit to tushardhole/jest that referenced this pull request Aug 21, 2017
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants