Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: refactor jest.retryTimes() documentation #13987

Merged
merged 2 commits into from
Apr 22, 2023
Merged

docs: refactor jest.retryTimes() documentation #13987

merged 2 commits into from
Apr 22, 2023

Conversation

mrazauskas
Copy link
Contributor

Summary

Refactoring jest.retryTimes() documentation so that admonitions could be used.

Test plan

Deploy preview.

mrazauskas
mrazauskas commented Mar 7, 2023
View reviewed changes
website/versioned_docs/version-28.x/JestObjectAPI.md
@@ -837,42 +837,54 @@ This function is not available when using legacy fake timers implementation.

## Misc

### `jest.setTimeout(timeout)`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only jest.retryTimes() entry was touched. jest.setTimeout() was simply moved under it.

website/versioned_docs/version-29.0/JestObjectAPI.md
@@ -837,44 +837,56 @@ This function is not available when using legacy fake timers implementation.

## Misc

### `jest.setTimeout(timeout)`
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about messed up diffs here and in few following files. There are no changes in jest.setTimeout(). It was simply moved under jest.retryTimes(). Split view helps to make this readable at least.

@mrazauskas
Copy link
Contributor Author

@SimenB Friendly ping. I guess this one just got overlooked.

By the way, great news regarding jestjs org! That was slow change, but still nice to see how things are moving forward.

@netlify
Copy link

netlify bot commented Apr 22, 2023

👷 Deploy request for jestjs pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit a2969d2

@SimenB SimenB merged commit 077e850 into jestjs:main Apr 22, 2023
@mrazauskas mrazauskas deleted the docs-refecto-jest.retryTimes branch April 22, 2023 07:49
DmitryMakhnev pushed a commit to DmitryMakhnev/jest that referenced this pull request May 5, 2023
@mrazauskas @DmitryMakhnev
docs: refactor jest.retryTimes() documentation (jestjs#13987)
43b62be
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrazauskas @SimenB @facebook-github-bot