-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Yarn Crowdin scripts #11082
Fix Yarn Crowdin scripts #11082
Conversation
Codecov Report
@@ Coverage Diff @@
## jest-website-v2 #11082 +/- ##
================================================
Coverage 64.22% 64.22%
================================================
Files 305 305
Lines 13255 13255
Branches 3235 3235
================================================
Hits 8513 8513
Misses 4050 4050
Partials 692 692 Continue to review full report at Codecov.
|
$pwd ? the crowdin cli should be run from the root so I think we can use |
Right, I meant My question is - why is the working directory different between |
I can double check tomorrow, but I'm fairly sure it's not the case - colon-scripts and |
You are right @arcanis my mistake, I had the Should be better now, ready to review again :) |
Deploy preview for jestjs ready! Built with commit 3e9cc5a |
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Summary
@SimenB @merceyz the change made here:
jest-website-migration@fd34cd0
It broke Crowdin translation download (didn't notice)
Crowdin is quite sensitive to the path from which you call its cli, and it seems using the
:
and global yarn script does not run from the place where the cli is declared, unlikeyarn workspace
.Test plan
Netlify preview works