This repository has been archived by the owner on Aug 14, 2019. It is now read-only.
Swift example working #1572
Merged
Swift example working #1572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
May 9, 2016 09:55
…oject only as per @jessesquires request of doing small pull requests.
…ViewController into SwiftExampleWorking # Conflicts: # SwiftExample/SwiftExample.xcodeproj/project.pbxproj # SwiftExample/SwiftExample/Assets.xcassets/AppIcon.appiconset/Contents.json # SwiftExample/SwiftExample/Base.lproj/Main.storyboard
Current coverage is 56.54%@@ develop #1572 diff @@
==========================================
Files 63 63
Lines 2333 2333
Methods 515 515
Messages 0 0
Branches 429 429
==========================================
Hits 1319 1319
Misses 783 783
Partials 231 231
|
|
@codecov-io Thats what I like to hear. I know your a bot🤖 but I still appreciate it. |
|
|
|
a bit large here, but 👍 |
MacMeDan
added a commit
to MacMeDan/JSQMessagesViewController
that referenced
this pull request
May 18, 2016
) (+3 squashed commits) Squashed commits: [96ec85d] Removed unused code, Added new landing page with additional settings page to let people configure things and learn how to do it themselves. [aecb14f] Swift example working (jessesquires#1572) * Initial Commit of Swift Implantation of JSQMessagesViewController. Project only as per @jessesquires request of doing small pull requests. * adding test * Add Icon * Adding viewControllers to let you actually see JSQ in action in swift. [943d8d9] Initial Commit of Swift Implantation of JSQMessagesViewController. Project only as per @jessesquires request of doing small pull requests. (jessesquires#1568)
2 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
This fixes issue #1473 .
What's in this pull request?