-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process suspended after shell command execution #3903
Comments
Reverting #3793 on master fix my issue. Maybe it is expected behavior now? |
No, it's not the expected behavior, and it doesn't happen for me. I can't explain why this happens to you, but I suspect it has something to do with what's in your |
It is not related to my zsh config. I also tested it on debian:latest docker image with default bash: docker run -it debian:latest
# In container shell
apt update && apt install -y git wget
wget https://github.com/jesseduffield/lazygit/releases/download/v0.44.0/lazygit_0.44.0_Linux_x86_64.tar.gz
tar xf lazygit_0.44.0_Linux_x86_64.tar.gz
git init
./lazygit |
Hm, ok. I can reproduce it on my Mac when doing
Note that it is my zsh that suspends the lazygit process, not bash. A bit of cursory googling finds this, which sounds related. I'm still not sure what to make of this, I'm hoping somebody with more knowledge about this can suggest a fix. I'd hate to have to revert #3793, it's a useful feature. Another data point: executing |
i have the same issue, i am so confuse that i search everywhere. oh.. |
…seduffield#3793)" Bugs: jesseduffield#3903 jesseduffield#3923 This reverts commit c72be6c, reversing changes made to da94ee7.
Just to add a bit more information, the behavior is reproducible also on WSL Ubuntu-24.04 with lazygit version 0.44.1_Linux_x86_64:
|
…seduffield#3793)" Bugs: jesseduffield#3903 jesseduffield#3923 This reverts commit c72be6c, reversing changes made to da94ee7.
…seduffield#3793)" Bugs: - jesseduffield/issues/3903 - jesseduffield/issues/3923 This reverts commit c72be6c, reversing changes made to da94ee7.
- **PR Description** In #3793 we changed the execution of shell commands to use an interactive shell (-i), because this allows users to use aliases or shell functions, which is a nice convenience. Since then, however, many users have reported problems with lazygit not coming back to the foreground after executing a shell command. Some users report that appending "; exit" to the end of the command line solves this. I don't really understand what the cause of this problem was, or why appending "; exit" solves it, but if it helps, let's do it. Fixes #3903, #3923, #3937. - **Please check if the PR fulfills these requirements** * [x] Cheatsheets are up-to-date (run `go generate ./...`) * [x] Code has been formatted (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#code-formatting)) * [ ] Tests have been added/updated (see [here](https://github.com/jesseduffield/lazygit/blob/master/pkg/integration/README.md) for the integration test guide) * [ ] Text is internationalised (see [here](https://github.com/jesseduffield/lazygit/blob/master/CONTRIBUTING.md#internationalisation)) * [ ] If a new UserConfig entry was added, make sure it can be hot-reloaded (see [here](https://github.com/jesseduffield/lazygit/blob/master/docs/dev/Codebase_Guide.md#using-userconfig)) * [ ] Docs have been updated if necessary * [x] You've read through your own file changes for silly mistakes etc
Describe the bug
When shell command executed with
:
hotkey lazygit process become suspended.To Reproduce
Steps to reproduce the behavior:
:
to enter shell command menudate
Expected behavior
Lazygit ask to press any key and after return to lazygit.
Screenshots
demo.webm
Version info:
Run
lazygit --version
and paste the result herecommit=2d0c7cb0fc85e3c262837eb9691813fa97e00e80, build date=2024-09-07T02:26:26Z, build source=binaryRelease, version=0.44.0, os=linux, arch=amd64, git version=2.39.2
Run
git --version
and paste the result heregit version 2.39.2
Additional context
Problem appears with version 0.44.0 and master.
The text was updated successfully, but these errors were encountered: