Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don’t nuke an activated virtual environment #367

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Conversation

jenstroeger
Copy link
Owner

So… calling make nuke usually fails because deactivate can’t be found when running make. That is because deactivate is actually a function sourced by the activate script

 > type -t deactivate 
function

and therefore it’s not available in the subprocess that runs the shell in the Makefile. This change prevents that failure, and instead just aborts make cleanly if the venv is activated.

@jenstroeger jenstroeger requested a review from behnazh October 30, 2022 06:26
@jenstroeger jenstroeger merged commit 4adf72b into staging Nov 7, 2022
@jenstroeger jenstroeger deleted the nuke-nuke branch November 7, 2022 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants