Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update pytest to drop dependency on vulnerable py package #354

Merged
merged 1 commit into from
Oct 25, 2022
Merged

fix: update pytest to drop dependency on vulnerable py package #354

merged 1 commit into from
Oct 25, 2022

Conversation

jenstroeger
Copy link
Owner

See also: pytest-dev/py#287 (comment)

This PR supersedes #353

@jenstroeger jenstroeger requested a review from behnazh October 25, 2022 15:49
@jenstroeger jenstroeger mentioned this pull request Oct 25, 2022
Closed
behnazh
behnazh approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@behnazh behnazh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving but I think we should take out make audit from build.yaml and dedicate a separate workflow for SCA analysis to prevent breaking builds in production.

@jenstroeger
Copy link
Owner Author

I think we should take out make audit from build.yaml and dedicate a separate workflow for SCA analysis to prevent breaking builds in production.

@behnazh agreed, and we’ll have a draft PR for such a change & discussion soon.

@jenstroeger jenstroeger merged commit db06702 into staging Oct 25, 2022
@jenstroeger jenstroeger deleted the update-pytest branch October 30, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behnazh behnazh behnazh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jenstroeger @behnazh