Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(ci): allow release when provenance generation fails #342

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

behnazh
Copy link
Collaborator

@behnazh behnazh commented Oct 11, 2022

This PR decouples the release and provenance generation and allows the release to proceed even if provenance generation fails.

@behnazh behnazh requested a review from jenstroeger October 11, 2022 23:02
Copy link
Owner

@jenstroeger jenstroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two questions, and w00t 🥳

.github/workflows/release.yaml Outdated Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
Copy link
Owner

@jenstroeger jenstroeger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thought below, but looks good 👍🏼

To be sure, even if the provenance job fails, we’ve still created a Release on Github with all its artifacts. The whole workflow can still fail, though, if the provenance job or the publish_provenance job fails?

.github/workflows/release.yaml Show resolved Hide resolved
.github/workflows/release.yaml Outdated Show resolved Hide resolved
@behnazh
Copy link
Collaborator Author

behnazh commented Oct 14, 2022

To be sure, even if the provenance job fails, we’ve still created a Release on Github with all its artifacts. The whole workflow can still fail, though, if the provenance job or the publish_provenance job fails?

That's correct. The version will be bumped, the tag and release will be created, and all the assets except for provenance will be uploaded when provenance generation fails. But the run itself will be shown as failed. I think that's good though to be aware that the provenance is missing.

@behnazh behnazh force-pushed the improve-release-stability branch from 8f5534f to cfb5082 Compare October 18, 2022 22:49
@behnazh behnazh force-pushed the improve-release-stability branch from cfb5082 to 6e1531d Compare October 27, 2022 04:35
@behnazh behnazh force-pushed the improve-release-stability branch from 6e1531d to f40526e Compare October 27, 2022 04:54
@behnazh behnazh requested a review from jenstroeger October 27, 2022 05:50
@behnazh behnazh merged commit 9ff28ef into staging Oct 27, 2022
@jenstroeger jenstroeger deleted the improve-release-stability branch October 30, 2022 05:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants