-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(ci): allow release when provenance generation fails #342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two questions, and w00t 🥳
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thought below, but looks good 👍🏼
To be sure, even if the provenance
job fails, we’ve still created a Release on Github with all its artifacts. The whole workflow can still fail, though, if the provenance
job or the publish_provenance
job fails?
That's correct. The version will be bumped, the tag and release will be created, and all the assets except for provenance will be uploaded when provenance generation fails. But the run itself will be shown as failed. I think that's good though to be aware that the provenance is missing. |
8f5534f
to
cfb5082
Compare
cfb5082
to
6e1531d
Compare
6e1531d
to
f40526e
Compare
This PR decouples the release and provenance generation and allows the release to proceed even if provenance generation fails.