fix: a Makefile’s SHELL variable is not an executable shebang #329
Conversation
Makefile
Outdated
| # https://stackoverflow.com/questions/10376206/what-is-the-preferred-bash-shebang | ||
| SHELL := /usr/bin/env bash | ||
| SHELL := bash | ||
| .SHELLFLAGS += -e |
There was a problem hiding this comment.
Can you please add a comment?
There was a problem hiding this comment.
Let me remove this flag for now. From the docs:
You can modify
.SHELLFLAGSto add the-eoption to the shell which will cause any failure anywhere in the command line to cause the shell to fail, but this could itself cause your recipe to behave differently. Ultimately you may need to harden your recipe lines to allow them to work with.ONESHELL.
So perhaps we should have a separte discussion about .ONESHELL and .SHELLFLAGS and exporting variables to the subshells.
Commit 1ebcf37.
Not sure what would be the purpose? |
See my comment above — let’s discuss this separately? |
I stumbled upon issues when I played with the
.ONESHELL:special target:Documentation on this is a little sparse, I thought.
I also think we should consider using the special target
.ONESHELL:: it runs the entire recipe in a single shell which would allow us to set & use environment variables within that recipe. So far we’ve danced aroundmakerunning every recipe line in its own shell, and that has complicated some of our process. In that context, it would also make sense to discuss.EXPORT_ALL_VARIABLES:.There’s also an option to silence
make’s command-line echoing, which may be usful?