Applying plugin modernization guidance #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aneveux
changed the title
|
Resolve conflicts with #49 please. |
aneveux
commented
Aug 21, 2023
Comment on lines
-43
to
-54
| private boolean containsUnclassifiedJobsFilter(View view) { | ||
| if (view instanceof ListView) { | ||
| ListView listView = (ListView)view; | ||
| for (ViewJobFilter filter: listView.getJobFilters()) { | ||
| if (filter instanceof UnclassifiedJobsFilter) { | ||
| return true; | ||
| } | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
There was a problem hiding this comment.
This was an unused private method.
jglick
reviewed
Aug 21, 2023
Co-authored-by: Jesse Glick <[email protected]>
jglick
reviewed
Aug 23, 2023
Co-authored-by: Jesse Glick <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello folks 👋
While following the modernization guide for plugins I noticed this plugin could use some of the updates.
This PR contains the following:
Please feel free to let me know if that PR needs any additional modification.
Thanks a lot for the review!
Testing done
Submitter checklist