add support for [email protected] hmac-sha2-256-etm@open…

[mpet]

add support for digests [email protected] [email protected] in trilead-ssh2 original implementation by Kenny Root in sshlib

[kuisathaverat]

I've rerun the CI again, it seems the changes break a couple of tests

[mpet]

I checked this exception:
Caused by: java.io.IOException: mark/reset not supported at java.io.InputStream.reset(InputStream.java:348) at com.trilead.ssh2.crypto.cipher.CipherInputStream.peekPlain(CipherInputStream.java:160) at com.trilead.ssh2.transport.TransportConnection.receiveMessage(TransportConnection.java:257) at com.trilead.ssh2.transport.TransportManager.receiveLoop(TransportManager.java:706) at com.trilead.ssh2.transport.TransportManager$1.run(TransportManager.java:502) at java.lang.Thread.run(Thread.java:750)
So I guess the inputstream directly does not support mark in this case. So I changed to BufferedInputStream that according to javadoc supports it.

"A BufferedInputStream adds functionality to another input stream-namely, the ability to buffer the input and to support the mark and reset methods. When the BufferedInputStream is created, an internal buffer array is created. As bytes from the stream are read or skipped, the internal buffer is refilled as necessary from the contained input stream, many bytes at a time. The mark operation remembers a point in the input stream and the reset operation causes all the bytes read since the most recent mark operation to be reread before new bytes are taken from the contained input stream."

Will add a new commit.

[mpet]

@kuisathaverat I have now pushed a new commit. Will the test cases start automatically?

[mpet]

I found that tests are automatically triggered. Now I can see a different problem.
Caused by: java.io.IOException: Remote sent corrupt MAC. at com.trilead.ssh2.transport.TransportConnection.checkMacMatches(TransportConnection.java:321) at com.trilead.ssh2.transport.TransportConnection.receiveMessage(TransportConnection.java:263) at com.trilead.ssh2.transport.TransportManager.receiveLoop(TransportManager.java:706) at com.trilead.ssh2.transport.TransportManager$1.run(TransportManager.java:502) at java.lang.Thread.run(Thread.java:750)

I will investigate.

[kuisathaverat]

do not forget to add a unit test to validate the new functionality.

[mpet]

@kuisathaverat I will try to fix the unit tests failing but I am not sure why it fails currently.

[mpet]

@kuisathaverat I have fixed the unit tests so they are not failing anymore.

[kuisathaverat]

It LGTM, but I want to perform a test using the SSH build Agents plugin that has more e2e tests than the library, give me a couple of days to find some time.

[mpet]

@kuisathaverat thx! Greatly appreciated. Just curious what is a "SSN build Agents plugin". Where can I read about it?

[kuisathaverat]

SSH build Agents plugin is one of plugins that uses this library in Jenkins

[mpet]

@kuisathaverat any result of the testing?

[mpet]

@kuisathaverat friendly reminder :-)

[mpet]

@kuisathaverat thanks a great deal for you prompt assistance!