-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow to use password encrypted keys #49
Conversation
I confirmed that |
It's bad enough that 3DES is still in use (it's incredibly slow compared to pretty much any other symmetric cipher; it might still be secure); I remember coming across this problem back when I was working on it. Depending on which JCA providers you have installed, 3DES has two different names apparently. |
|
||
MessageDigest digest = null; | ||
try { | ||
digest = MessageDigest.getInstance("MD5"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: is there a @SuppressWarnings
of some sort to apply here? Any sort of static code scanner will end up crying about MD5 usage despite it being valid here.
Co-authored-by: Matt Sicker <[email protected]>
see JENKINS-63601
regression #45