JENKINS-73889: Cannot reuse an open socket

[mpet]

See JENKINS-XXXXX.](https://issues.jenkins.io/browse/JENKINS-73889)

[mpet]

@kuisathaverat could you please review the code?

[kuisathaverat]

Too many compiled sources from other repos, it will be hard to maintain, Is there an official Docker image for NetOpeer?

[mpet]

@kuisathaverat no there is no official docker image. I cannot see any other way to do it. What do you suggest?

[kuisathaverat]

I do not feel comfortable adding 6min build from code five libs and one binary, for a feature we will not use in Jenkins.

[kuisathaverat]

I pushed the Docker image to this repository as ghcr.io/jenkinsci/trilead-ssh2:netopeer-3.5.1, so we will keep the Dockerfile, but we will use a compiled Docker image. I saw the Docker image is huge, 1.6GB; maybe we can split it into two stages or remove compilation stuff

[mpet]

@kuisathaverat so no need to change the testcontainer code? Yes I agree it is large but could not really find something that supports ssh call home. Any optimization is fine for me.
Do you expect anything more from me?

[kuisathaverat]

I forgot I have to make it public

https://github.com/jenkinsci/trilead-ssh2/pkgs/container/trilead-ssh2

[mpet]

I also tried this locally:

$ docker build -t ghcr.io/jenkinsci/trilead-ssh2:netopeer-3.5.1 .
[+] Building 0.8s (2/2) FINISHED                                                                                                                                                                                                                            docker:default
 => [internal] load build definition from Dockerfile                                                                                                                                                                                                                  0.6s
 => => transferring dockerfile: 2B                                                                                                                                                                                                                                    0.3s 
 => [internal] load .dockerignore                                                                                                                                                                                                                                     0.6s
 => => transferring context: 2B                                                                                                                                                                                                                                       0.3s 
ERROR: failed to solve: failed to read dockerfile: open /var/lib/docker/tmp/buildkit-mount4081330339/Dockerfile: no such file or directory

[kuisathaverat]

you need to change to the folder test/docker first

[mpet]

@kuisathaverat When we use testcontainers we should be able to pull the image. However testcontainers cannot access the image:

FINE: http-outgoing-2 << "{"message":"Head "[https://ghcr.io/v2/jenkinsci/trilead-ssh2/manifests/netopeer-3.5.1\](https://ghcr.io/v2/jenkinsci/trilead-ssh2/manifests/netopeer-3.5.1%5C)": unauthorized"}[\n]"

[kuisathaverat]

It works on my local and in the CI

[mpet]

@kuisathaverat fixed comments. Netopeer2 is not easy to replace unless you know of an alternative.

[kuisathaverat]

Suggested change

	libpam0g-dev
	libpam0g-dev \
	&& rm -rf /var/lib/apt/lists/*

[kuisathaverat]

Suggested change

	ENV EDITOR vim
	RUN rm -fr /opt/dev
	ENV EDITOR vim

[kuisathaverat]

Suggested change

	EXPOSE 830
	EXPOSE 4334
	# start netopeer2 server.
	CMD ["/usr/sbin/netopeer2-server", "-d", "-v2 3"]
	#CMD ["/usr/sbin/netopeer2-server", "-d", "-c", "SSH"]
	EXPOSE 830
	EXPOSE 4334
	# start netopeer2 server.
	CMD ["/usr/sbin/netopeer2-server", "-d", "-v2 3"]
	#CMD ["/usr/sbin/netopeer2-server", "-d", "-c", "SSH"]

[kuisathaverat]

Suggested change

	# This Docker image is build and push to the repository it takes about 6 min to build
	# The reason to pre-build it is because it compiles five libraries and an application everytime we run the test
	# docker build -t ghcr.io/jenkinsci/trilead-ssh2:netopeer-3.5.1 .

[mpet]

@kuisathaverat in testcontainers we use docker image with name 'netopeer2'. Will testcontainers pick it up if we use
netopeer-3.5.1?

[kuisathaverat]

yes, you have to change to use a Docker image instead of build one

GenericContainer redis = new GenericContainer("ghcr.io/jenkinsci/trilead-ssh2:netopeer-3.5.1")
    .withExposedPorts(830)
    .withExposedPorts(4334)
    .waitingFor(Wait.forLogMessage(".*SOME STARTING MESSAGE*\\n", 1));

[mpet]

@kuisathaverat ok I can change this. And if I want to run this locally?

[kuisathaverat]

IIRC ghcr.io it is public if the repo is public so it should work directly

[mpet]

@kuisathaverat do you have more comments or is there anything else to change?

[mpet]

@kuisathaverat do you have more comments or is there anything else to change?

Friendly reminder :-)

[mpet]

@kuisathaverat what is this

[kuisathaverat]

All the PRs generate an incremental build package, which is a binary with the code from the PR. This allows for the distribution of early versions before the release.

By the way, I'm sorry, but it will take a few more days for me to review the changes here.