Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add testNG symbol for Pipeline syntax clarity #155

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

MarkEWaite
Copy link
Contributor

@MarkEWaite MarkEWaite commented Sep 19, 2022

Add testNG symbol for Pipeline syntax generator

Allows the Pipeline snippet syntax generator to suggest syntax for TestNG results and makes it easier to read Pipeline definitions.

Pipeline snippet syntax generator does not correctly handle two boolean flags, but it feels better to have most of the syntax generator working rather than hold this change until all of the syntax generator is working.

Includes an automated test that confirms the symbol testNG() works for scripted Pipeline. Tested interactively to confirm the new syntax is working for declarative Pipeline. Existing automated test already checked that the old syntax is still working.

See the README for examples.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Allows the Pipeline snippet syntax generator to suggest syntax for
TestNG results and makes it easier to read Pipeline definitions.

Pipeline snippet syntax generator does not correctly handle two boolean
flags, but it feels better to have most of the syntax generator working
rather than hold this change until all of the syntax generator is
working.

Includes an automated test that confirms the symbol `testNG()` works
for scripted Pipeline.  Tested interactively to confirm tha new syntax
is working for declarative Pipeline.  Existing automated test already
checked that the old syntax is still working.
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 19, 2022
@MarkEWaite MarkEWaite added enhancement Improvement or new feature and removed documentation Improvements or additions to documentation labels Sep 23, 2022
@MarkEWaite MarkEWaite merged commit aea5873 into jenkinsci:master Sep 26, 2022
@MarkEWaite MarkEWaite deleted the add-pipeline-symbol branch September 26, 2022 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant