-
Notifications
You must be signed in to change notification settings - Fork 411
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom messages per Build result #445
Conversation
@KreAch3R I've linked all the related issues in your description so that when this gets merged they will all get closed |
69cd7d5
to
f3f0bdd
Compare
Original idea from jenkinsci#169 (Enhance Custom Message Functionality by @csogilvie) Discussion in jenkinsci#385 I re-wrote it almost completely on top of the current master
f3f0bdd
to
970211b
Compare
@@ -594,7 +656,13 @@ public SlackJobProperty(String teamDomain, | |||
boolean includeTestSummary, | |||
boolean showCommitList, | |||
boolean includeCustomMessage, | |||
String customMessage) { | |||
String customMessage, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm oops misread that..
2.3 is about 2 years old I think... you can have a look at releases to see details |
Thank you for your reply!! 😄 |
You said you were using 2.3... |
Oh, my bad, I just got the version wrong (2.3 and 2.30) 😆 |
Following #169 #385
I re-wrote this patch for the current master source.
While I'm there, sync the notify booleans with the custom message boxes.
Closes #163
Closes #360
Closes #284
Closes #212