slack send should not require message #434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
approved these changes
Dec 4, 2018
|
Thanks @Casz will get this into 2.5 |
|
Tests failing @Casz will get into next release |
timja
reviewed
Dec 4, 2018
src/main/java/jenkins/plugins/slack/workflow/SlackSendStep.java
Outdated
Show resolved
Hide resolved
jetersen
commented
Dec 4, 2018
|
Tests runs fine locally, Jenkins CI is just having a field day 😅 |
timja
approved these changes
Dec 4, 2018
|
good to go once jenkins plays ball 👍 |
timja
referenced
this pull request
Dec 4, 2018
|
failed :( |
Co-Authored-By: casz <[email protected]>
|
@timja Test passed 😅 |
|
will release later today |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #351