Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add multiple channel comment to slackSend docs #399

Merged
merged 1 commit into from
Sep 21, 2018

Conversation

bskarda
Copy link
Contributor

@bskarda bskarda commented Sep 21, 2018

The global plugin configuration where the comment about accepting a csv
string for channels is only rendered in the plugin documentation. This
changes adds that useful piece of knowledge to the slackSend step
documentation like in https://jenkins.io/doc/pipeline/steps/slack/ where
the global config is not easily available.

The global plugin configuration where the comment about accepting a csv
string for channels is only rendered in the plugin documentation. This
changes adds that useful piece of knowledge to the slackSend step
documentation like in https://jenkins.io/doc/pipeline/steps/slack/ where
the global config is not easily available.
@bskarda
Copy link
Contributor Author

bskarda commented Sep 21, 2018

@kmadel @gurumaia little doc update to improve the step docs on the jenkins.io documentation if either of you have a few spare minutes 😄

@kmadel kmadel merged commit 1d7592b into jenkinsci:master Sep 21, 2018
@bskarda bskarda deleted the slackSend_channel_docs branch September 21, 2018 14:01
@bskarda
Copy link
Contributor Author

bskarda commented Sep 21, 2018

Thanks for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants