Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to show the list of commits (title+author) #30

Merged
merged 1 commit into from
Feb 3, 2015
Merged

Updated to show the list of commits (title+author) #30

merged 1 commit into from
Feb 3, 2015

Conversation

peergum
Copy link
Contributor

@peergum peergum commented Nov 24, 2014

when build is successful and if the corresponding option
is selected in the build's configuration (true by default)
and corrected buildServerUrl display format

@jenkinsadmin
Copy link
Member

Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests

@samrocketman
Copy link
Member

I guess I'll start maintaining this plugin. I don't have any experience developing Jenkins plugins but if I can get my own environment set up and learn to release then I'll do it. This may take about a week.

@samrocketman
Copy link
Member

Can you drag in a screenshot? I'm curious what this looks like.

@samrocketman
Copy link
Member

Can you pull in the latest changes from master because your project produces more merge conflicts than I can resolve. See #37 for a description of what I similarly tried to resolve your conflicts.

@peergum
Updated to show the list of commits (title+author)
dc3d7d0 
when build is successful and if the corresponding option
is selected in the build's configuration (true by default)
@peergum
Copy link
Contributor Author

peergum commented Feb 2, 2015

I solved the conflicts with current HEAD.
Here's a sample of commit details shown on a successful build:
screen shot 2015-02-01 at 9 26 10 pm
The display of commit details can be enabled by checking a box in the advanced section of the config (only on successful builds - not sure there is an interest in showing these for failures...)

@samrocketman
Copy link
Member

Candidate for merge means I will first merge your change locally, compile locally, and test locally in Jenkins before merging.

@samrocketman samrocketman self-assigned this Feb 2, 2015
@samrocketman samrocketman merged commit dc3d7d0 into jenkinsci:master Feb 3, 2015
samrocketman added a commit that referenced this pull request Feb 3, 2015
@samrocketman
Merge PR #30 Updated to show the list of commits
b0088c5 
(title+author).
@samrocketman
Copy link
Member

In 34b0709, I combined the two advanced sections and placed them at the bottom.

@peergum
Copy link
Contributor Author

peergum commented Feb 3, 2015

Great. Thanks!

@samrocketman samrocketman mentioned this pull request Feb 4, 2015
Merged
@samrocketman samrocketman modified the milestone: slack-1.7 Feb 4, 2015
@samrocketman samrocketman mentioned this pull request Feb 4, 2015
Closed
samrocketman added a commit that referenced this pull request Feb 4, 2015
@samrocketman
Merge PR #44 Patching #30: Always show user list
ec01e8a 
in slack
@samrocketman samrocketman mentioned this pull request Feb 4, 2015
Merged
samrocketman added a commit that referenced this pull request Feb 10, 2015
@samrocketman
Preparing for 1.7 release
d6047eb 
New features:

* Advanced settings
  * Team domain and token can be specified per project; falls back to
    global config if not specified (#19)
  * Post a list of commits with the build notification (title and author
    of commit) (#30, #44, #45)
  * Include JUnit test summary in build notifications (#25)
* Use colors when sending a message using slack (#20, #24).  Also, the
  start notifications use the color of the last build result (#43)
* Support for authenticated proxies (#14)
* Test Connection button (#46, #28)
* Option to disable subsequent notifications on build failures (#46, #15)

Improvements:

* Report 'return to normal' on transition from unstable to success (#21)
* Improved logging.

Bug fixes:

* When changing the global slack settings the slack config in jobs are
  updated as well (#26, #12)
* Fix NullPointerException and output log message if slack is not
  configured (#35, JENKINS-26066)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samrocketman samrocketman

Labels
None yet
Projects
None yet
Milestone
slack-1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@peergum @jenkinsadmin @samrocketman