Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use ionicon instead of custom image in side panel #214

Merged
merged 1 commit into from
Dec 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,10 @@
</build>

<dependencies>
<dependency>
<groupId>io.jenkins.plugins</groupId>
<artifactId>ionicons-api</artifactId>
</dependency>
<dependency>
<groupId>org.jenkins-ci.plugins</groupId>
<artifactId>matrix-project</artifactId>
Expand Down
12 changes: 10 additions & 2 deletions src/main/java/jenkins/advancedqueue/PriorityConfiguration.java
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@

import org.acegisecurity.context.SecurityContext;
import org.acegisecurity.context.SecurityContextHolder;
import org.jenkins.ui.icon.IconSpec;
import org.jenkinsci.plugins.workflow.support.steps.ExecutorStepExecution;
import org.kohsuke.stapler.QueryParameter;
import org.kohsuke.stapler.StaplerRequest;
Expand All @@ -74,7 +75,7 @@
* @since 2.0
*/
@Extension
public class PriorityConfiguration extends Descriptor<PriorityConfiguration> implements RootAction, Describable<PriorityConfiguration> {
public class PriorityConfiguration extends Descriptor<PriorityConfiguration> implements RootAction, IconSpec, Describable<PriorityConfiguration> {

private final static Logger LOGGER = Logger.getLogger(PriorityConfiguration.class.getName());

Expand Down Expand Up @@ -104,11 +105,18 @@ public PriorityConfiguration() {
}
}

@Override
public String getIconFileName() {
return null;
}

@Override
public String getIconClassName() {
if (!checkActive()) {
return null;
}
return "/plugin/PrioritySorter/advqueue.svg";

return "symbol-swap-vertical-outline plugin-ionicons-api";
}

@Override
Expand Down
89 changes: 0 additions & 89 deletions src/main/webapp/advqueue.svg

This file was deleted.