Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internationalize the user interface #148

Merged
merged 2 commits into from
May 22, 2022

Conversation

MarkEWaite
Copy link
Contributor

Internationalize the user interface to allow Crowdin translation

Many of the plugin strings were internationalized references from the Java, Jelly, and Groovy source code using the form:

${%Internationalized string}

That form of reference does not require an entry in the English language properties file. Unfortunately, without an entry in the English language properties file, Crowdin does not find the source string to be used as a basis for translation.

This pull request converts from the previous form into:

${Internationalized_string_reference}

The property file is created with the internationalized string reference symbol and the internationalized string, like this:

Internationalized_string_reference=Internationalized string

That provides an English language source string, "Internationalized string" that Crowdin will detect and offer for translators and proofreaders.

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

Preparing to connect the plugin to Crowdin for localization.
@MarkEWaite MarkEWaite added the chore Reduces maintenance effort by changes not directly visible to users label May 22, 2022
@github-actions github-actions bot removed the chore Reduces maintenance effort by changes not directly visible to users label May 22, 2022
@MarkEWaite MarkEWaite added the enhancement Improvement or new feature label May 22, 2022
@MarkEWaite MarkEWaite merged commit 29afb48 into jenkinsci:master May 22, 2022
@MarkEWaite MarkEWaite deleted the internationalize branch May 22, 2022 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvement or new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant