[JENKINS-70808] Add a specific isRestartable method that accept a sta… #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Dohbedoh
commented
Mar 16, 2023
Dohbedoh
commented
- JENKINS issue(s):
- JENKINS-70808
- Description:
- Add a method to specifically check if a stage is restartable that will return as soon as one is found and will not check the status of other irrelevant stages. To be consumed downstream by blueocean-pipeline-api-impl at https://github.com/jenkinsci/blueocean-plugin/blob/49440310221d3e68040c0a46842b8a91d0a577be/blueocean-pipeline-api-impl/src/main/java/io/jenkins/blueocean/rest/impl/pipeline/PipelineNodeImpl.java#L189-L193.
- Users/aliases to notify:
- @olamy
olamy
added a commit
to jenkinsci/blueocean-plugin
that referenced
this pull request
Mar 16, 2023
Signed-off-by: Olivier Lamy <[email protected]>
olamy
added a commit
to jenkinsci/blueocean-plugin
that referenced
this pull request
Mar 16, 2023
…d and cached then future usage will be really quick... add TODO for using jenkinsci/pipeline-model-definition-plugin#596 Signed-off-by: Olivier Lamy <[email protected]>
olamy
added a commit
to jenkinsci/blueocean-plugin
that referenced
this pull request
Mar 16, 2023
…d and cached then future usage will be really quick... add TODO for using jenkinsci/pipeline-model-definition-plugin#596 Signed-off-by: Olivier Lamy <[email protected]>
olamy
added a commit
to jenkinsci/blueocean-plugin
that referenced
this pull request
Mar 16, 2023
…d and cached then future usage will be really quick... add TODO for using jenkinsci/pipeline-model-definition-plugin#596 Signed-off-by: Olivier Lamy <[email protected]>
jglick
reviewed
Mar 16, 2023
| for (ModelASTStage s : stages.getStages()) { | ||
| if(s.getName().equals(stageName)) { | ||
| return !Utils.stageHasStatusOf(s.getName(), execution, | ||
| StageStatus.getSkippedForFailure(), StageStatus.getSkippedForUnstable()); |
There was a problem hiding this comment.
So a failed/unstable stage is not restartable? The logic here is unclear. Is this just a copy / adaptation of code elsewhere?
There was a problem hiding this comment.
@jglick it is the same logic as isRestartable() but specific to a single stage.
This was referenced Mar 16, 2023
|
might need to take into account 821aabd |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.