Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Revert "Add retry to signtool" (#183)" #184

Merged
merged 1 commit into from
Jun 4, 2020
Merged

Revert "Revert "Add retry to signtool" (#183)" #184

merged 1 commit into from
Jun 4, 2020

Conversation

olblak
Copy link
Member

@olblak olblak commented Jun 4, 2020

This reverts commit 3e5efb2.

I propose to revert this change as it's not related to the current issue

@olblak olblak requested review from slide, MarkEWaite and timja June 4, 2020 15:19
MarkEWaite
MarkEWaite approved these changes Jun 4, 2020
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This retry logic was not the issue that broke the Jenkins weekly build.

Thanks to @slide and @timja for the investigation of the Microsoft security fix that caused the issue.

@timja timja merged commit f3a8f93 into jenkinsci:INFRA-910-core-release-automation Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slide slide slide approved these changes

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@olblak @slide @MarkEWaite @timja