use IP intead of dns record for PKGSERVER #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timja
reviewed
Apr 22, 2020
env/release.mk
Outdated
| @@ -6,7 +6,7 @@ | |||
| export JENKINS_URL=https://cloudbees.ci.cloudbees.com/ | |||
|
|
|||
| # the host to publish bits to | |||
| export PKGSERVER=mirrorbrain@pkg.jenkins.io | |||
| export PKGSERVER=mirrorbrain@52.202.51.185 | |||
There was a problem hiding this comment.
why not create an ssh dns record?
There was a problem hiding this comment.
like pkg.origin.jenkins.io ?
There was a problem hiding this comment.
This will allow us to request certificate using letsencrypt in the futur
timja
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are correctly experimenting Fastly for pkg.jenkins.io so we had to change the dns recored while we can still download from pkg.jenkins.io as we did, we cannot anymore push packages through that domain